[lldb][sbapi] Fix API break in SBDebugger broadcast bits (#90261) #8645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chelcassanova
force-pushed
the
cherrypick/fix-sbdebugger-bits
branch
from
4b3cdb3 to
aa27930
Compare
|
@swift-ci please test |
JDevlieghere
approved these changes
Apr 26, 2024
llvm#87409 removed the broadcast bits from SBDebugger and placed them in `lldb-enumerations.h`. This is API-breaking so this commits places the enum back into `SBDebugger.h` and references the bits from `lldb-enumerations.h`. rdar://127128536 (cherry picked from commit a4c21d1)
chelcassanova
force-pushed
the
cherrypick/fix-sbdebugger-bits
branch
from
aa27930 to
3d283d9
Compare
medismailben
approved these changes
Apr 26, 2024
|
@swift-ci please test |
|
@swift-ci please test windows |
bulbazord
approved these changes
Apr 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
llvm#87409 removed the broadcast bits from SBDebugger and placed them in
lldb-enumerations.h. This is API-breaking so this commits places the enum back intoSBDebugger.hand references the bits fromlldb-enumerations.h.rdar://127128536
(cherry picked from commit a4c21d1)